persistent torrent-totals hack

[b4rt]

One other thing, when deleting, the torrent should prob be removed from the database to clean up after itself and not just have the totals updated.

this was intentional as i dont want to loose my seeding-stats when reseeding "old" torrents.
it should even work if you rename torrents.
maybe i integrate an option to flush stats on demand.

[b4rt]

Have the bits of this I wanted hacked into my code and came across a small maths bug.

Code:

This line
$sharekill = (int) ($sharekill - (($upTotal / $upWanted) * 100));

should be
$sharekill = (int) ($sharekill - (($upTotal / $torrentSize) * 100));

Was causing the wrong percentages to be generated.

oops. must have been a cut+paste thingy because i have it correct in downloaddetails.
(and i didnt notice it on my 100% test-cases of course )
thanks for seeing it and giving me feedback about it.

[ryaner]

this was intentional as i dont want to loose my seeding-stats when reseeding "old" torrents.
it should even work if you rename torrents.
maybe i integrate an option to flush stats on demand.

Very good point. Hadn't thought about that.

[b4rt]

one thing just came in mind about the hack... the checkbox is kinda useless.
because you never set the sharekill-commandline-param direct anymore.
so just no checkbox should behave exactly like having one. (in what is really the result of operations)

btw i just tested things with transmission-client and works as well.
so i moved the param-recalc code from tornado-handler to the clienthandler-baseclass

[ryaner]

Thought the idea behind the checkbox was to force it to send the sharekill value ignoring the previous saved data? Personally I removed it since a) I just want to seed 200% total and b) I was too lazy to hack it in

[b4rt]

Thought the idea behind the checkbox was to force it to send the sharekill value ignoring the previous saved data? Personally I removed it since a) I just want to seed 200% total and b) I was too lazy to hack it in

yeah but stripped down to what it does:
in case you dont change it its the same if you pass 200 as param or if you reload it from the db (ignoring passed value).
and in case you change it.. you want a "force-set" anyway.